Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QueryEditor): save query on Cmd/Ctrl + S #944

Merged
merged 15 commits into from
Jul 5, 2024
Merged

feat(QueryEditor): save query on Cmd/Ctrl + S #944

merged 15 commits into from
Jul 5, 2024

Conversation

NaiSidera
Copy link
Contributor

No description provided.

@NaiSidera NaiSidera requested a review from Raubzeug June 25, 2024 23:21
@Raubzeug Raubzeug requested a review from ValeraS June 26, 2024 10:49
ValeraS
ValeraS requested changes Jun 27, 2024
View reviewed changes
src/containers/Tenant/Query/QueryEditor/keybindings.ts Outdated Show resolved Hide resolved
src/containers/Tenant/Query/QueryContext.tsx Outdated Show resolved Hide resolved
src/containers/Tenant/Query/QueryContext.tsx Outdated Show resolved Hide resolved
src/containers/Tenant/Query/SaveQuery/SaveQuery.tsx Outdated Show resolved Hide resolved
@Raubzeug Raubzeug force-pushed the 887-hotkey-save-query branch from cefb571 to 4b2f0fc Compare June 27, 2024 14:12
@Raubzeug
Copy link
Contributor

closes #887

ValeraS
ValeraS requested changes Jun 28, 2024
View reviewed changes
src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx Outdated Show resolved Hide resolved
src/utils/keyboard.ts Outdated Show resolved Hide resolved
src/containers/Tenant/Query/utils/queryActions.tsx Outdated Show resolved Hide resolved
@Raubzeug Raubzeug linked an issue Jun 28, 2024 that may be closed by this pull request
Hotkey for saving query #887
Closed
@Raubzeug Raubzeug force-pushed the 887-hotkey-save-query branch from 4b2f0fc to 69af4f0 Compare June 28, 2024 14:40
@Raubzeug Raubzeug force-pushed the 887-hotkey-save-query branch from 69af4f0 to 5ac6a89 Compare June 28, 2024 14:56
artemmufazalov
artemmufazalov previously approved these changes Jul 2, 2024
View reviewed changes
@Raubzeug Raubzeug force-pushed the 887-hotkey-save-query branch from d32a4a4 to 976342d Compare July 4, 2024 10:48
@Raubzeug Raubzeug merged commit 1077e2e into main Jul 5, 2024
4 checks passed
@Raubzeug Raubzeug deleted the 887-hotkey-save-query branch July 5, 2024 09:54
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeraS ValeraS ValeraS approved these changes

@artemmufazalov artemmufazalov artemmufazalov left review comments

@Raubzeug Raubzeug Awaiting requested review from Raubzeug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotkey for saving query
4 participants
@NaiSidera @Raubzeug @ValeraS @artemmufazalov